[codex] ci: harden wasm SIMD gates - #94
Merged
Merged
Conversation
Signed-off-by: Nelson Spence <nelson@projectnavi.ai>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Nelson Spence (Fieldnote-Echo)
marked this pull request as ready for review
May 28, 2026 15:51
Nelson Spence (Fieldnote-Echo)
requested a review
from Navi Bot (project-navi-bot)
as a code owner
May 28, 2026 15:51
Review Summary by QodoHarden wasm SIMD CI gates with explicit linting
WalkthroughsDescription• Add clippy linting for wasm SIMD128 and aarch64 NEON targets • Preserve -D warnings flag in wasm build and test RUSTFLAGS • Make popcount test gate exact with single-test assertion • Install aarch64-unknown-linux-gnu target and clippy component Diagramflowchart LR
A["CI Toolchain Setup"] -->|"Add clippy + aarch64 target"| B["Enhanced Linting"]
B -->|"Lint wasm32 + simd128"| C["Clippy wasm32"]
B -->|"Lint aarch64 NEON"| D["Clippy aarch64"]
E["RUSTFLAGS"] -->|"Add -D warnings"| F["Build & Test"]
F -->|"Exact test gate"| G["Popcount Test Validation"]
File Changes1. .github/workflows/ci.yml
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require review |
Copilot started reviewing on behalf of
Nelson Spence (Fieldnote-Echo)
May 28, 2026 15:51
View session
There was a problem hiding this comment.
Pull request overview
Hardens the wasm SIMD CI lane by adding clippy lint coverage for both wasm32 simd128 and aarch64 NEON cfg-gated kernels under -D warnings, restoring -D warnings in the wasm build/test RUSTFLAGS overrides, and tightening the wasmtime popcount test so it can no longer silently pass when the filter matches zero tests.
Changes:
- Add
clippycomponent andaarch64-unknown-linux-gnutarget to the wasm job's Rust toolchain install, plus two newcargo clippy --no-depssteps targeting wasm32 (+simd128) and aarch64. - Re-include
-D warningsin theRUSTFLAGSenv for the wasm build and wasmtime test steps. - Run the wasmtime test with the fully-qualified path and
--exact, tee the output, and asserttest result: ok. 1 passed;so a rename can't silently produce a zero-test pass.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Bot review disposition:
No remediation or deferral issue needed. |
project-navi-bot
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippyplus theaarch64-unknown-linux-gnutarget to the wasm SIMD job-D warnings-D warningsin wasm build/testRUSTFLAGSCloses #20.
Validation
cargo test --lib util::tests::popcount_helpers_match_naive -- --exactRUSTFLAGS='-D warnings -C target-feature=+simd128' cargo clippy -p ordvec --lib --target wasm32-unknown-unknown --no-deps -- -D warningsRUSTFLAGS='-D warnings' cargo clippy -p ordvec --lib --target aarch64-unknown-linux-gnu --no-deps -- -D warningsutil::tests::popcount_helpers_match_naive -- --exact, including the1 passedgrepactionlintv1.7.12zizmor --offline --persona=regular .github/workflows/